-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable filesync with debug #2351
Comments
That sounds good, however it can also be confusing: Sync has to be configured by supplying sync patterns. If a file gets changed which does not match any of the sync patterns, the container is usually rebuilt. Now if some changes get applied (via sync in debug-mode) and others are not (because they would require a rebuild in debug-mode), this can be a bit confusing. |
It seems some language runtimes, like Python, do not support a debugger-controlled hot-swap capability. VS Code and the Debug Adapter Protocol do not support installing code-changes either. |
@briandealwis Do I understand you correctly, that this also speaks against enabling sync in debug mode? |
The opposite: Python's pydevd has some support for reloading changes from disk ( |
Is this still an issue? |
Yes. |
debug
currently disables the Skaffold watcher to prevent Skaffold from redeploying artifacts on file changes: having a debug session ripped out when in progress is a suboptimal user experience! And many runtimes support installing changes, normally handled by the IDE.But a side-effect is that this also disables the filesync functionality. We should be able to forego artifact redeployment while still supporting filesync.
The text was updated successfully, but these errors were encountered: