Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve caching #1755

Merged
merged 5 commits into from
Mar 11, 2019
Merged

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented Mar 7, 2019

This PR:

  • makes sure caching can still work without a local daemon (check remote registry if the image exists even without local Docker)
  • makes sure caching works with kaniko & docker in GCB (tag images with imageName:cacheHash as well in the cloudbuild.yaml and args to kaniko)

TODO:

  • make sure caching works with Jib in GCB / Jib locally

Continues work on #1740

@codecov-io
Copy link

codecov-io commented Mar 7, 2019

Codecov Report

Merging #1755 into master will decrease coverage by 0.05%.
The diff coverage is 48.64%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1755      +/-   ##
=========================================
- Coverage   47.05%     47%   -0.06%     
=========================================
  Files         130     130              
  Lines        6241    6270      +29     
=========================================
+ Hits         2937    2947      +10     
- Misses       3003    3021      +18     
- Partials      301     302       +1
Impacted Files Coverage Δ
pkg/skaffold/build/kaniko/run.go 0% <0%> (ø) ⬆️
pkg/skaffold/plugin/environments/gcb/docker.go 100% <100%> (ø) ⬆️
pkg/skaffold/plugin/environments/gcb/desc.go 55.1% <41.66%> (-1.42%) ⬇️
pkg/skaffold/build/cache.go 55.98% <47.05%> (+0.42%) ⬆️
pkg/skaffold/plugin/environments/gcb/types.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd6f373...d044daf. Read the comment docs.

@dgageot dgageot merged commit 21308f8 into GoogleContainerTools:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants