Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Story Duration Default - No notification to user who tries to set it higher than 20 seconds #12599

Closed
bmattb opened this issue Nov 1, 2022 · 4 comments · Fixed by #12645
Closed
Assignees
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Group: Settings Type: Bug Something isn't working

Comments

@bmattb
Copy link

bmattb commented Nov 1, 2022

Bug Description

Originally reported by @barklund
If you set the default interval to a number higher than 20, it’s capped at 20, but with no indication that such a cap exists. Same thing happens inside the editor. We should have some sort of notification & description

Expected Behaviour

The user should be notified that there is a max value, and that going over that value isn't possible

Steps to Reproduce

Screenshots

Additional Context

  • Plugin Version:
  • WordPress Version:
  • Operating System:
  • Browser:
@bmattb bmattb added Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Group: Settings Pod: Prometheus Type: Bug Something isn't working labels Nov 1, 2022
@kkalarickal
Copy link

Regarding duration values, it is also possible to set up to 15 decimal digits which is probably not necessary/elegant
image

Cc: @swissspidy

@swissspidy
Copy link
Collaborator

Can you please file a separate enhancement request for this? Thanks!

@merapi merapi mentioned this issue Nov 7, 2022
8 tasks
@merapi
Copy link
Contributor

merapi commented Nov 8, 2022

Regarding duration values, it is also possible to set up to 15 decimal digits which is probably not necessary/elegant image

Cc: @swissspidy

I know it's possible, but do we want decimals at all?
https://amp.dev/documentation/components/amp-story-page/#auto-advance-after-[optional]

@swissspidy
Copy link
Collaborator

It feels more like an oversight that we allowed it. We can certainly remove that to keep it simple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Changes that impact accessibility and need corresponding review (e.g. markup changes). Group: Settings Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants