Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: Convert pageDataUrls provider #12668

Closed
swissspidy opened this issue Nov 10, 2022 · 2 comments · Fixed by #12727
Closed

TypeScript: Convert pageDataUrls provider #12668

swissspidy opened this issue Nov 10, 2022 · 2 comments · Fixed by #12727
Assignees
@miina
Labels
P2 Should do soon Package: Design System /packages/design-system Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️

Comments

@swissspidy
Copy link
Collaborator

No description provided.

@swissspidy swissspidy added P2 Should do soon Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ Pod: Prometheus Package: Design System /packages/design-system labels Nov 10, 2022
@timarney timarney self-assigned this Nov 21, 2022
@timarney timarney mentioned this issue Nov 28, 2022
Merged
8 tasks
@swissspidy swissspidy added the Status: Blocked On hold for the time being label Dec 9, 2022
@swissspidy
Copy link
Collaborator Author

Since this provider uses storyPageToNode, this is currently blocked by missing types for components like DisplayElement, which in turn depends on useLocalMedia too

@miina
Copy link
Contributor

miina commented Dec 30, 2022

Since the previous dep is resolved in #12667, we can finish it up. Picking this up.

@miina miina added Pod: Prometheus and removed Status: Blocked On hold for the time being Pod: WP labels Dec 30, 2022
@miina miina self-assigned this Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miina miina

Labels
P2 Should do soon Package: Design System /packages/design-system Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TypeScript: Convert pageDataUrls provider GoogleForCreators/web-stories-wp
3 participants
@timarney @swissspidy @miina