Remove serf gossip rules #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially addresses #152
lawliet89
force-pushed
the
rm-serf-gossip
branch
from
e12a746 to
4f8ab38
Compare
guangie88
reviewed
Sep 17, 2018
modules/core/README.md
Outdated
| Due to a [limitation](https://github.com/GovTechSG/terraform-modules/issues/152) in how Terraform | ||
| deals with `count`, we are unable to automatically provision the security group rules for | ||
| Nomad (both servers and clients) and Vault instances to retrieve | ||
| [Consul Sef Gossip](https://www.consul.io/docs/internals/gossip.html) traffic. The instances can |
guangie88
approved these changes
Sep 17, 2018
qbiqing
pushed a commit
that referenced
this pull request
Mar 10, 2020
* Use updated terraform modules * Use updated terraform modules v2 * Use updated terraform modules v3 * Update terraform-modules * Update consul AMI * Update terraform-modules * Update AMI * Update to master branch submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152