Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versionning discrepancies between npm and github #36

Open
Overdrivr opened this issue Apr 25, 2017 · 3 comments
Open

Versionning discrepancies between npm and github #36

Overdrivr opened this issue Apr 25, 2017 · 3 comments

Comments

@Overdrivr
Copy link

Currently, the npm version 0.4.14 is 2 patch version ahead of github 0.4.12. I'm guessing versions are manually set before pushing to npm; This should be fixed and eventually automated so that we get consistent versionning across both.

It's a problem for debugging since we cannot know for sure what version of the code hosted on Github is locally installed. And it's also an issue when looking at the sources to fill the documentation gaps.

@dkapanidis
Copy link
Contributor

From reviewing a bit the packaging in npm, the latest two versions (0.4.13 and 0.4.14) are not properly bundled. The index.js was not compiled with the new changes on the .ts files.

How can we automate this? Any references to libraries with automated process? Automation should probably take into account also #35.

@Overdrivr
Copy link
Author

If you setup Travis CI for the project, you can tell him to push to npm registry only for tagged commits, only on master branch. Tags can be created through git and pushed or created directly in Github by creating a new release.

Taking #35 into account is then just a matter of properly writing the packaging script ran by the CI.

@junjun16818 I can make a PR if you are interested. Let me know.

@shenshouer
Copy link
Collaborator

@Overdrivr Thank you very much and welcome for the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants