Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Localisable component text based on page language #2342

Closed
senchden opened this issue Oct 18, 2019 · 4 comments
Closed

[Feature request] Localisable component text based on page language #2342

senchden opened this issue Oct 18, 2019 · 4 comments

Comments

@senchden
Copy link

It would be great to create pages that would share the component layout, but allow to edit text for each component based on language value set externally (one page per language). Not sharing layout per language is not optimal since if a user edits not only the component text, but also the page layout, all pages in other languages must be edited to use the new layout, which is not easily maintainable. Personally, I envision this as component inner text not being propagated to HTML inner text on export, but rather as pairs of component id (or text key) and text values.

@artf
Copy link
Member

artf commented Oct 19, 2019

I18n module is already in the roadmap

@artf artf closed this as completed Oct 19, 2019
@senchden
Copy link
Author

Does this module have any tentative date of implementation?

@varadero
Copy link

varadero commented Nov 6, 2019

Looking at the branch named i18n and i18n module code here: https://github.com/artf/grapesjs/tree/i18n/src/i18n it looks like this module is not for localizing page content that the users are creating but just the GapesJS interface itself, is that right @artf ? We also would like to have module that will enable the users to provide different texts of the pages they create for different languages. If the i18n module on the roadmap is not about supporting different page languages, do you have an idea how can we implement it in a "GrapesJS" way ?

@artf
Copy link
Member

artf commented Nov 6, 2019

@varadero

it looks like this module is not for localizing page content that the users are creating but just the GapesJS interface itself, is that right

correct

We also would like to have module that will enable the users to provide different texts of the pages they create for different languages

Well, the content has nothing to do with the core library, this is something you have to implement by yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants