Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Do you have plans to remove dependency on Document.execCommand in RTE? #2853

Closed
mikeholczer opened this issue Jun 24, 2020 · 5 comments

Comments

@mikeholczer
Copy link

I noticed that in #74 when the move to the Pell based editor is listed it's use of Document.execCommand was mentioned as a liability. I see now that according to https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand it's consider Obsolete, so we were wondering if you have plans to switch to a new editor?

@artf
Copy link
Member

artf commented Jul 1, 2020

so we were wondering if you have plans to switch to a new editor?

New editor? What would be the alternative?

@mikeholczer
Copy link
Author

What additional information are you looking for? I did a quick google and found https://quilljs.com/ doing a quick search of it's source on github, the only use of execCommand I see is https://github.com/quilljs/quill/blob/fd400525d551315b6fa9a4d4783e1c7dbad57827/formats/image.js#L32 which sounds like minimal impact.

@artf
Copy link
Member

artf commented Jul 5, 2020

No, I mean a native alternative

@mikeholczer
Copy link
Author

Why does it need to be a native solution? That account also has a lower level system in https://github.com/quilljs/parchment which is what they used to implement the editor.

@artf
Copy link
Member

artf commented Jul 6, 2020

I'd like to avoid putting external libraries in the core library (indeed we still have to extract some of them).
If you need quilljs you can try to add it as a custom RTE.
I close it as there is no real alternative to the native API (unfortunately)

@artf artf closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants