Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using magic number indexes in the node system #1490

Open
Keavon opened this issue Dec 7, 2023 · 2 comments
Open

Avoid using magic number indexes in the node system #1490

Keavon opened this issue Dec 7, 2023 · 2 comments
Labels
Graphene Involves the node graph system/engine used by Graphite

Comments

@Keavon
Copy link
Member

Keavon commented Dec 7, 2023

There are tons of fragile index values like 0, 1, 2, etc. used to reference inputs and outputs (amongst other things?) between nodes and node internals. This is extremely fragile, makes it hard to refactor, provides a difficult developer experience, lacks self-documenting clarity, and is hard to debug.

One potential solution could be using enums. But thinking through some alternative ways to achieve this could also be good.

@Keavon Keavon added Cleanup Graphene Involves the node graph system/engine used by Graphite labels Dec 7, 2023
@Keavon Keavon added this to Task Board Dec 7, 2023
@github-project-automation github-project-automation bot moved this to Short-Term in Task Board Dec 7, 2023
@Kakapio
Copy link
Contributor

Kakapio commented Jan 19, 2024

Hey Keavon,

I'd be interested in contributing to this. Any chance we can chat about this issue?

Thanks

@Keavon
Copy link
Member Author

Keavon commented Jan 22, 2024

Hi @Kakapio, I don't think this issue is likely to be an easily-solved one that's easy for newcomers to jump on. But I'd encourage you to ask me on Discord for some advice about which issues you can get started with based on your background and I can direct you to some issues that are easier to begin with. Thanks!

@Keavon Keavon moved this from Short-Term to Medium-Term in Task Board Jun 9, 2024
@Keavon Keavon removed the Rust label Dec 30, 2024
@Keavon Keavon removed the Cleanup label Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graphene Involves the node graph system/engine used by Graphite
Projects
Status: Medium-Term
Development

No branches or pull requests

2 participants