Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uncaught TypeError: Cannot read property 'replace' of undefined #5

Closed
Jinestic opened this issue May 13, 2021 · 6 comments
Closed

Uncaught TypeError: Cannot read property 'replace' of undefined #5

Jinestic opened this issue May 13, 2021 · 6 comments
Assignees
@oviirup
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Jinestic
Copy link

Download button gets stuck on waiting and extension shows below error.
Playlist: https://www.jiosaavn.com/s/playlist/0f8d02afa160d2ea7d9ef4bedf677fd9/YouTube/x3VOnhuvOfLc1EngHtQQ2g__

image
@Jinestic
Copy link
Author

Jinestic commented May 13, 2021 •
edited
Loading

Might be related: Extension is not able to download some single songs as well, for example Shape of You gives "Sorry! Can not download this song" error

@oviirup oviirup added bug Something isn't working good first issue Good for newcomers labels May 13, 2021
@oviirup
Copy link
Owner

oviirup commented May 13, 2021

Thank you for your report @jineshpatel30, I will look into that.
The problem is mainly because some songs are unavailable and some songs don't have preview urls.

@oviirup oviirup added this to the Fix error of unavailable songs milestone May 13, 2021
@oviirup oviirup pinned this issue May 13, 2021
@Jinestic
Copy link
Author

Jinestic commented May 13, 2021 •
edited
Loading

Thank you for your report @jineshpatel30, I will look into that.
The problem is mainly because some songs are unavailable and some songs don't have preview urls.

Is it possible to get location of playlist downloads before it convert to zip? (I'm assuming somewhere in temporary folder.) I was able to download 390 of 395 song from a playlist and 5 got stuck but that is resulting in No Zip creation so if it possible to extract other downloaded song it would be great.

Just FYI: Telegram Bot @JioDLBot was able to download Shape of You song and it has bit higher quality with M4A (Not much noticeable) than 320 Mp3 downloaded by this extension. Though bot doesn't support playlist download so your extension has a clear edge 👍

@Jinestic
Copy link
Author

Jinestic commented May 13, 2021 •
edited
Loading

@GrayGalaxy I was able to download those 5 stuck songs separately via this extension, so playlist download getting stuck and not creating zip has some other issue than server "Unavailable"

PS: On second attempt to download whole playlist from scratch after removing those 5 stuck song in the first attempt resulted in 2 new songs getting stuck. :(

Playlist link if you want to check yourself.
https://www.saavn.com/s/playlist/0f8d02afa160d2ea7d9ef4bedf677fd9/All/G5VPN,3BrT4wkg5tVhI3fw__

PS: Seems like Jio blocked my ip for multiple downloads!

image

@oviirup
Copy link
Owner

oviirup commented May 13, 2021 •
edited
Loading

@jineshpatel30 I am actually aware of download getting stuck for long list. You can mention this to new issue.

You can directly postthis type of things to issues, rather than posting as comment.

@oviirup oviirup mentioned this issue May 13, 2021
Closed
@oviirup oviirup modified the milestones: Fix error of unavailable songs, Version 0.7 May 14, 2021
@oviirup oviirup mentioned this issue May 14, 2021
Merged
@oviirup oviirup self-assigned this May 14, 2021
oviirup added a commit that referenced this issue May 14, 2021
@oviirup
issue fixed #5
df2ff32
@oviirup
Copy link
Owner

oviirup commented May 14, 2021

I am closing this string as it is fixed in df2ff32

@oviirup oviirup closed this as completed May 14, 2021
@oviirup oviirup unpinned this issue May 15, 2021
@oviirup oviirup mentioned this issue Feb 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oviirup oviirup

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jinestic @oviirup