Fix repeated dialog popup notifying of new updates when there aren't any if you have bundled updates with external updates #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nabled-when-using-bundled-updates
Otozinclus
pushed a commit
to Otozinclus/Ryujinx
that referenced
this pull request
Oct 30, 2024
…yubing#30) * Move encoder state to be tied to command buffer, so preload and background cbs have their own encoder state * Texture buffer/data flush, blit shader fix
WilliamWsyHK
pushed a commit
to WilliamWsyHK/Ryujinx-Ryubing
that referenced
this pull request
Dec 6, 2024
* Are symlinks the problem? (P.S., yep, symlinks were most definitely the problem lol)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a minor issue when you have bundled updates in your XCI and also have newer updates for that same Title when you have auto update selection turned on where a dialog would popup every time Ryujinx loads stating that it has found new updates (as the update fails to save with error below).
This occurs because the auto update selection code is not unselecting the already selected bundled update and the save is failing to save with this warning in the logs:
"00:00:04.237 |E| GUI.ApplicationLibraryThread Application SaveTitleUpdatesJson: Tried to save two updates as 'IsSelected' for 0100000000010000"
This code change fixes this issue by ensuring that we set the already selected update to be not selected when we select the new one, this then allows the save to occur correctly and the dialog does not keep showing upon initial load.