Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run build doesn't work #191

Closed
dadiorchen opened this issue Dec 7, 2021 · 6 comments · Fixed by #192
Closed

npm run build doesn't work #191

dadiorchen opened this issue Dec 7, 2021 · 6 comments · Fixed by #192
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@dadiorchen
Copy link
Collaborator

  1. clone the repo
  2. npm ci (I didnt' use npm i, maybe this is the reason, I'm not sure)
  3. npm run build
  10005 root@aliyun:~/treetracker-wallet-web# npm run build
  10006
  10007 > [email protected] build
  10008 > GENERATE_SOURCEMAP=false react-scripts build
  10009
  10010 Creating an optimized production build...
  10011 Failed to compile.
  10012
  10013 Cannot read properties of undefined (reading 'includes')
  10014
  10015
  10016 root@aliyun:~/treetracker-wallet-web#

  • If you want to join the slack community (some resources need the community member's permission), please leave your email address.
@dadiorchen dadiorchen added bug Something isn't working good first issue Good for newcomers labels Dec 7, 2021
@dadiorchen
Copy link
Collaborator Author

@VWRoli seems there are some weird npm things going on currently ;(

@Siddhant-K-code this happens on your side right?

@dadiorchen
Copy link
Collaborator Author

@VWRoli why we need to upgrade to react 17?

@Siddhant-K-code
Copy link
Member

Yeah, I was also curious that what is the need for this : node-version >= 16

@fustroli
Copy link
Member

fustroli commented Dec 7, 2021

Not working on my side either with my original copy of the repo.

@VWRoli why we need to upgrade to react 17?

We did not upgrade to 17, the project was initialized with 17.

EDIT: I tried to get rid of all the undefined variables in the project, but no luck, still not working.
I was thinking can this be related to that we run the mock server in another project @dadiorchen?

EDIT II: npm start still works fine for me

@dadiorchen
Copy link
Collaborator Author

@VWRoli interesting, theoretically, mock server things should have an impact on this

Me too, I can run npm start but can not build, the embarrassing situation is that the command doesn't throw any error message when failing

@fustroli
Copy link
Member

fustroli commented Dec 8, 2021

Success

fustroli added a commit to fustroli/treetracker-wallet-web that referenced this issue Dec 8, 2021
fustroli added a commit to fustroli/treetracker-wallet-web that referenced this issue Dec 8, 2021
Siddhant-K-code added a commit that referenced this issue Dec 8, 2021
* fix: issue #191 npm run build does not work

* fix: `treating warnings as errors `

because `process.env.CI` was true.

Co-authored-by: Siddhant Khare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants