fix: inherit Query type from schema superclass #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grxy
changed the title
grxy
approved these changes
Apr 19, 2023
grxy
pushed a commit
that referenced
this pull request
Apr 19, 2023
## [3.6.4](v3.6.3...v3.6.4) (2023-04-19) ### Bug Fixes * inherit Query type from schema superclass ([#241](#241)) ([0efb37e](0efb37e))
|
🎉 This PR is included in version 3.6.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Kaytal
pushed a commit
to lensrentals/apollo-federation-ruby
that referenced
this pull request
Oct 1, 2024
Kaytal
pushed a commit
to lensrentals/apollo-federation-ruby
that referenced
this pull request
Oct 1, 2024
## [3.6.4](Gusto/apollo-federation-ruby@v3.6.3...v3.6.4) (2023-04-19) ### Bug Fixes * inherit Query type from schema superclass ([Gusto#241](Gusto#241)) ([0efb37e](Gusto@0efb37e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
ApolloFederation::Schemato properly inherit theQuerytype from any superclasses so code like the following works as expected:We use this subclassing pattern quite a bit in tests to avoid mutating our "real" schema class.