Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian packaging #160

Closed
ghisvail opened this issue Apr 28, 2016 · 109 comments
Closed

Debian packaging #160

ghisvail opened this issue Apr 28, 2016 · 109 comments
Assignees

Comments

@ghisvail
Copy link
Contributor

I am opening a separate meta issue for all my questions / remarks / requests, whilst dealing with the packaging work on Debian (like #159).

@ghisvail
Copy link
Contributor Author

Amongst the list of dependencies for hdf-compass:

setup_args['install_requires'] =\
    [
        "numpy",
        "matplotlib>=1.5",
        "cartopy[plotting]",
        "h5py",
        "wxPython==3.0.2",
        "hydroffice.bag>=0.2.10",
        "pydap",
        "requests"
    ]

Debian is currently missing cartopy, hydroffice.bag and pydap. Cartopy is supposedly being worked on, hydroffice.bag is in my backlog and pydap is not available. We have dap, but I am assuming it is outdated and superseded by pydap. I wonder which of these dependencies are trully necessary for running hdf-compass and which of those could be moved to extra_requires.

@giumas
Copy link
Collaborator

giumas commented Apr 28, 2016

Does it help?

    setup_args['install_requires'] =\
    [
        "numpy",
        "matplotlib>=1.5",
        "h5py",
        "wxPython==3.0.2",
        "requests"
    ]
    setup_args['extras_require'] =\
    {
        "GeoNodes": ["cartopy[plotting]", ],  # required for visualization of GeoArray and GeoSurface nodes
        "BAG": ["hydroffice.bag>=0.2.10", ],  # required by BAG plugin
        "OpenDAP": ["pydap", ],  # required by OpenDAP plugin
    }

@ghisvail
Copy link
Contributor Author

It does, yes. So that means we do have all the essentials in place in Debian.

@giumas giumas self-assigned this Apr 28, 2016
@giumas
Copy link
Collaborator

giumas commented Apr 28, 2016

As hydroffice.bag maintainer, I hope that you can also add the BAG plugin.. Incidentally, this plugin is currently the only one that takes advantage of the GeoNodes dependency to geo-visualize the data (if present).

@ghisvail
Copy link
Contributor Author

so it would require cartopy too?

@giumas
Copy link
Collaborator

giumas commented Apr 28, 2016

Nope! It reverts to visualize the data as simple Array nodes if cartopy is missing.

@ghisvail
Copy link
Contributor Author

Could you guys provide a scalable and / or PNG version of the application icon? Right now, I am running imagemagick during the package build to generate a freedesktop compliant .png from the .ico but a .svg would make it look better, regardless of the screen resolution or application launcher.

@giumas
Copy link
Collaborator

giumas commented Apr 28, 2016

@ghisvail
Copy link
Contributor Author

I now have a working package for 0.6.0b4. You should consider merging #162 which would benefit packaging efforts for other distributions. In addition, you guys might want to have a look at the AppStream standard for better discovery in software stores.

@giumas
Copy link
Collaborator

giumas commented Apr 28, 2016

@ghisvail
Copy link
Contributor Author

Perfect. The packaging is ready on my end. I'll should perhaps wait for the final v0.6.0 tag before doing the submission?

@giumas
Copy link
Collaborator

giumas commented Apr 30, 2016

@ghisvail Great!

For the release decision, we need somebody from the HDF Group: @jreadey ? @hyoklee ? @ajelenak-thg ? and I would also invoke the opinion of @andrewcollette

@giumas
Copy link
Collaborator

giumas commented Apr 30, 2016

@ghisvail can I hope that the packaging is with the BAG plugin?

@jreadey
Copy link
Member

jreadey commented May 1, 2016

I'd like to have frozen binaries built and tested for Mac & Windows before releasing v0.6.0.

@giumas
Copy link
Collaborator

giumas commented May 1, 2016

Does it mean that these binaries do not work? https://github.com/HDFGroup/hdf-compass/releases/tag/v0.6.0b3 Or that is required that binaries are built on HDF Group's machines?

Incidentally, I am also a bit concerned about the lack of recent developer time put on the project. Is this a project that the HDF Group wants to really push for?

@jreadey
Copy link
Member

jreadey commented May 2, 2016

The binaries don't work on my Mountain Lion System. And I would say the binaries need to be built on HDF Group's machine if we are to be the one's to distribute them.

I think at this point it makes sense to move the minimal OS X version to Yosemite (10.10). For example I notice that Chrome is no longer supported on 10.8 and in general it's hard to get the binary build dependencies on 10.8.

Sorry for the lack of time the HDF Group has been able to put in to this project recently. Compass is a great tool, but it has to take a back seat to projects that customers are paying us for. I will spend some time this week to get the build setup for v0.6.0.

@giumas
Copy link
Collaborator

giumas commented May 2, 2016

The binaries don't work on my Mountain Lion System.

What is the error? I would like to understand better what is the general issue. Do we really need to have a frozen app for each supported OS X?

I will spend some time this week to get the build setup for v0.6.0.

This is great!

@ghisvail
Copy link
Contributor Author

ghisvail commented May 2, 2016

I will spend some time this week to get the build setup for v0.6.0.

Awesome. Then, what I can do is submit the packaging of v0.6.0b5 for review (which always take some time to complete) and update to v0.6.0 once it is released. Is that ok?

@jreadey
Copy link
Member

jreadey commented May 2, 2016

Re: the runtime error, it was similar to this: http://stackoverflow.com/questions/25926495/symbol-not-found-sincos-stret.

In general, binaries built on one version of OS X won't run on previous versions. So I'm trying to setup a build machine with a OS X release recent enough to be able to build Compass w/ the various plugins and old enough that most Mac users will have it or a newer release. I wasn't able to find a download for 10.10 on the Mac developer site: https://developer.apple.com/osx/download/. Does anyone know if they are still keeping a Yosemite DMG around?

@giumas
Copy link
Collaborator

giumas commented May 3, 2016

I wasn't able to find a download for 10.10 on the Mac developer site: https://developer.apple.com/osx/download/. Does anyone know if they are still keeping a Yosemite DMG around?

I am afraid that Yosemite was already removed.. Bad guys!!

BTW, if you downloaded it in the past, shouldn't it be in your purchases in the App Store?

@jreadey
Copy link
Member

jreadey commented May 3, 2016

Good idea! - I do have it on my App Store/Purchased tab. I'll give it a go.

@jreadey
Copy link
Member

jreadey commented May 4, 2016

@giumas - I was able to follow your wiki and create a dmg on OS X 10.10! Since this is 10.10, I didn't need to deal with the WxPython work-around.

The binary is here: s3://hdfgroup.download/HDFCompass/0.6.0b5/HDFCompass.dmg, try it out and let me know if you see any issues.

Next, I'll try the same on Windows 7.

@giumas
Copy link
Collaborator

giumas commented May 4, 2016

@giumas
Copy link
Collaborator

giumas commented May 4, 2016

It works on my Yosemite machine:

vmplayer_2016-05-04_08-46-12

@jreadey
Copy link
Member

jreadey commented May 4, 2016

Great! Yes I meant to say https://...

@giumas
Copy link
Collaborator

giumas commented May 5, 2016

@jreadey I have found much easier the building on Windows. Are you hitting issues?

@giumas
Copy link
Collaborator

giumas commented Jun 13, 2016

@jreadey It works on my machine

@jreadey
Copy link
Member

jreadey commented Jun 15, 2016

@giumas - can you do the PyPI release?

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

@jreadey of course, yes.We should also add a release tag on GitHub. Let me know when you decide that is time.

@jreadey
Copy link
Member

jreadey commented Jun 15, 2016

Ok - done!

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

The py2app script is also outdated.. Actually, I did not test it since a while. Do you? https://github.com/HDFGroup/hdf-compass/blob/develop/setup.py2app.py#L49

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

@jreadey
Copy link
Member

jreadey commented Jun 15, 2016

No, I haven't used py2app since we switched to using pyinstaller for both windows and Mac. Delete it?
The version strings hidden everywhere are a pain.

@jreadey
Copy link
Member

jreadey commented Jun 15, 2016

I can delete README.txt as well. Anything else?

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

I am double-checking.. it doesn't seem to me that these small issues require a new tag

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

Do you plan to provide the dmg for Mac?

@jreadey
Copy link
Member

jreadey commented Jun 15, 2016

Yes, but I won't be able to get to it this week - I'm traveling.

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

The license year is not updated: https://github.com/HDFGroup/hdf-compass/blob/develop/docs/license.rst

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

Are you freezing with console=True and debug=True? https://github.com/HDFGroup/hdf-compass/blob/master/HDFCompass.1file.spec#L89

@jreadey
Copy link
Member

jreadey commented Jun 15, 2016

Yes.

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

@jreadey Can you create an account on PyPI? I believe that it is a good idea if I add you.. just in case.

@jreadey
Copy link
Member

jreadey commented Jun 15, 2016

I have a PyPI account. Userid is: john_readey.

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

Just added

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

@ghisvail This ticket is getting too long.. and capturing too much stuff. I would like to close it as soon as the debian package is accepted!

@ghisvail
Copy link
Contributor Author

Since v0.6.0 is out, it is now my turn to work. I'll report here if I have issues / comments, but it should be fine. I will close it once the package is submitted.

Cheers,

@ghisvail
Copy link
Contributor Author

I need a tar.gz release on PyPI please.

@giumas
Copy link
Collaborator

giumas commented Jun 15, 2016

added

@giumas
Copy link
Collaborator

giumas commented Jul 27, 2016

@ghisvail updates? can we close this ticket?

@ghisvail
Copy link
Contributor Author

It is currently sitting in the NEW queue for approval by the release team. Will close once it is accepted.

@ghisvail
Copy link
Contributor Author

ghisvail commented Sep 1, 2016

hdf-compass is now available in Debian. Closing.

@ghisvail ghisvail closed this as completed Sep 1, 2016
@jreadey
Copy link
Member

jreadey commented Sep 1, 2016

@ghisvail - cool! Does this mean I can just do Apt-get on a recent Debian install to get it? What's the package name?

@ghisvail
Copy link
Contributor Author

ghisvail commented Sep 1, 2016

https://packages.debian.org/sid/hdf-compass

It will transition to Debian Stretch (Debian testing, future stable) tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants