Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add primitive caching #22

Closed
csala opened this issue May 23, 2018 · 1 comment · Fixed by #100
Closed

Add primitive caching #22

csala opened this issue May 23, 2018 · 1 comment · Fixed by #100
Assignees
Milestone

Comments

@csala
Copy link
Contributor

csala commented May 23, 2018

The primitive JSON files should be looked for in at least two places:

  • the package primitives directory
  • a custom user directory, such as ./mlblocks_primitives

There should also be a method to add a custom folder where primitives should be taken from.

There should also be a dict somewhere in the package where the loaded primitives would be stored "in memory" to avoid having to load them from disk more than once.

@csala csala added this to the 0.3.1 milestone Sep 20, 2018
@csala csala changed the title Add primitive finding and caching Add primitive caching Sep 20, 2018
@csala csala removed this from the 0.3.1 milestone Sep 20, 2018
@csala csala added wontfix and removed new feature labels Sep 20, 2018
@csala csala added this to the 0.3.1 milestone Sep 20, 2018
@csala csala added new feature and removed wontfix labels Sep 20, 2018
@csala
Copy link
Contributor Author

csala commented Sep 20, 2018

Most of this issue has already been implemented, but the caching is not in place yet.

The behavior will be:

  • MLBlock will store the loaded primitive JSON as a dict in memory, to avoid having to read it again if the same primitive is used again.
  • Both MLBlock and MLPipeline will accept a new argument cache, which will default to True.
  • If this is True, the dict will be looked up and used. If it is set to False, it will always re-load the JSON from disk, and overwrite the previously stored dict.

@csala csala modified the milestones: 0.3.1, 0.3.2 May 16, 2019
@csala csala modified the milestones: 0.3.2, 0.3.1 Jul 8, 2019
@csala csala closed this as completed in #100 Aug 7, 2019
@csala csala self-assigned this Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant