Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typeit types the site name 3 times #222

Closed
xpufx opened this issue Sep 13, 2021 · 5 comments
Closed

typeit types the site name 3 times #222

xpufx opened this issue Sep 13, 2021 · 5 comments
Labels
bug Something isn't working needs more info Issue requires more information from poster

Comments

@xpufx
Copy link

xpufx commented Sep 13, 2021

I just migrated from loveit. I hadn't changed anything in themes/loveit but I do have a few simple overrides.

I have typeit enabled for the site name at the top. typeit types the name of the site 3 times.

May be related to #213

@xpufx xpufx added the bug Something isn't working label Sep 13, 2021
@xpufx xpufx changed the title [BUG] Some problem... typeit types the site name 3 times Sep 13, 2021
@HEIGE-PCloud
Copy link
Owner

HEIGE-PCloud commented Sep 13, 2021

Can you provide more information, maybe a demo site for easier debugging? Since TypeIt is clearly working correctly on the documentation site, I cannot reproduce that on my side.

@HEIGE-PCloud HEIGE-PCloud added the needs more info Issue requires more information from poster label Sep 13, 2021
@xpufx
Copy link
Author

xpufx commented Sep 13, 2021

I deployed again with typeit enabled for the header name ([params.header.title] name) . I checked on windows firefox and android kiwi. It takes a few clicks around the site for it to appear.

It actually seems to be adding one more every time you click something. Honestly it's hilarious to watch :)

@HEIGE-PCloud
Copy link
Owner

image

Have you updated the theme to the latest commit? The theme.js file on your site does not seem to contain that fix I create for #213

@HEIGE-PCloud
Copy link
Owner

HEIGE-PCloud commented Sep 13, 2021

It actually seems to be adding one more every time you click something. Honestly it's hilarious to watch :)

Yes, because the DoIt theme loads new pages with PJAX loading (#78). The re-loading bug is caused by creating a new TypeIt instance while the old one is not destroyed. The latest commit should contain a fix preventing that from happening.

@xpufx
Copy link
Author

xpufx commented Sep 13, 2021

I was on the latest release. I cloned the code now and it's working properly. Thanks.!

@xpufx xpufx closed this as completed Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs more info Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants