Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4] Set up GitHub Dependabot for dependency scanning #90

Closed
3 tasks done
ninamak opened this issue Jul 16, 2021 · 6 comments
Closed
3 tasks done

[4] Set up GitHub Dependabot for dependency scanning #90

ninamak opened this issue Jul 16, 2021 · 6 comments
Assignees

Comments

@ninamak
Copy link
Contributor

ninamak commented Jul 16, 2021

Goals

  • Set up dependency scanning to ensure we're checking for vulnerabilities with any of the libraries we use.

Tasks

  • Research how other 18F teams have set up GitHub Dependabot (e.g., TTAHub)
  • Research on GitHub docs on how to configure it
  • Set it up

Conditions of Acceptance

Additional Context

Resources

@ninamak ninamak added this to the Milestone 1 milestone Jul 16, 2021
@ninamak ninamak changed the title Set up security analysis tools Set up dependency scanning Jul 20, 2021
@ninamak ninamak changed the title Set up dependency scanning Set up GitHub Dependabot for dependency scanning Jul 20, 2021
@ninamak ninamak changed the title Set up GitHub Dependabot for dependency scanning [4] Set up GitHub Dependabot for dependency scanning Jul 20, 2021
@carjug carjug self-assigned this Aug 13, 2021
@carjug
Copy link
Contributor

carjug commented Aug 13, 2021

Screen Shot 2021-08-13 at 12 39 39 PM

Dependabot has been enabled on the repository, but I have yet to see it work. I merged a test PR with a package in the requirements.txt that is out of date and has a security vulnerability (according to this snyk page: https://snyk.io/vuln/SNYK-PYTHON-KERAS-1536745), I set it at v2.4.3, and I'm not sure how often dependabot runs, so I'm going to leave as is over the weekend and see if we get any alerts by Monday. Will obviously revert this change when we see if dependabot is working correctly.

@carjug
Copy link
Contributor

carjug commented Aug 17, 2021

Screen Shot 2021-08-17 at 12 31 00 PM

Woo!!

Deleting Keras from the requirements.txt as it was just done as a test of dependabot

@carjug
Copy link
Contributor

carjug commented Aug 17, 2021

@amymok @alexsoble @ninamak dependabot set up! verify at https://github.com/HHS/OPRE-OPS/pulls where you can see an automated dependabot PR for updating the django package.

@alexsoble
Copy link
Contributor

@carjug Woooohoooo! LGTM! As well as checking out the automated dependabot PR I took a look at #128, looks good! 🎉

@amymok
Copy link
Contributor

amymok commented Aug 17, 2021

Yay! LGTM! 🎉 ❣️

@amymok amymok removed the Amy Review label Aug 17, 2021
@ninamak
Copy link
Contributor Author

ninamak commented Aug 18, 2021

I don't have much to add here, so if everyone else is 👍 , then LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants