ADR for front-end code quality tools #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daphnegold
force-pushed
the
daphnegold/issue-102-front-end-tools
branch
from
6448d33 to
e27d087
Compare
daphnegold
force-pushed
the
daphnegold/issue-102-front-end-tools
branch
from
e27d087 to
51a6eed
Compare
daphnegold
requested review from
acouch,
widal001,
lucasmbrown-usds and
SammySteiner
| - **Enforces security:** Tooling should assist us in identifying security concerns and vulnerabilities. | ||
| - **Well-maintained:** We have a preference towards libraries that are widely adopted and have active maintainers. | ||
|
|
||
| ## Options Considered |
There was a problem hiding this comment.
do we want to consider something like immutableJS to enforce immutability? i know there are lots of pros and cons to that!
There was a problem hiding this comment.
Would this be alongside Typescript? Typescript will add immutability functionality that we can use as we desire, and I think that's sufficient for now. I'd need to do a deeper dive into immutable.js to see if it offers something additional. I can add it to the documentation so it is tracked as an option.
1 task
SammySteiner
approved these changes
Jul 14, 2023
Definitely, I think that's ideal as we iterate! |
Replaces reference to HHS/grants-api with HHS/grants-equity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #102
Time to review: 10 mins
Context for reviewers
Describes decision for front-end code quality tooling. Assumes we are using the Next.js template repository, however, set of tooling is extensible to any solution we choose.