Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Configure pre-commit hooks #223

Open
2 tasks
daphnegold opened this issue Jul 12, 2023 · 0 comments
Open
2 tasks

[Task]: Configure pre-commit hooks #223

daphnegold opened this issue Jul 12, 2023 · 0 comments
Labels
project: grants.gov Grants.gov Modernization tickets

Comments

@daphnegold
Copy link
Contributor

daphnegold commented Jul 12, 2023 •
edited
Loading

Summary

Blocked by #110

Pre-commit has been added to the project. The api, frontend, and infra components have since been added to the project. Each of these has a linter (infra's can be re-introduced) and tests that can be added to pre-commit so that tests and lints for specific file types can be run before committing.

This will save time, for both committers and code reviewers, as changes won't be introduced before linters and tests have been run and is widely adopted as a best practice.

Acceptance criteria

  • Linters and tests (?) and desired tools have been added to pre-commit
  • Update README.md
@daphnegold daphnegold mentioned this issue Jul 12, 2023
Closed
18 tasks
@widal001 widal001 added the project: grants.gov Grants.gov Modernization tickets label Jul 14, 2023
@daphnegold daphnegold mentioned this issue Jul 14, 2023
Merged
@daphnegold daphnegold moved this from Backlog to Sprint Backlog in Simpler.Grants.gov Product Backlog Jul 18, 2023
@daphnegold daphnegold moved this from Sprint Backlog to Backlog in Simpler.Grants.gov Product Backlog Jul 18, 2023
@SammySteiner SammySteiner mentioned this issue Jul 19, 2023
Closed
17 tasks
@sumiat sumiat added this to the Technical Improvement milestone Sep 18, 2023
@daphnegold daphnegold mentioned this issue Sep 18, 2023
Closed
2 tasks
@sumiat sumiat modified the milestones: Technical Improvements, [Epic]: Developer Tools Sep 18, 2023
@sumiat sumiat modified the milestones: Developer Tools, Technical Improvements Sep 26, 2023
@acouch acouch mentioned this issue Feb 16, 2024
Open
@margaretspring margaretspring removed this from the Technical improvements - Cross-Deliverables milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
project: grants.gov Grants.gov Modernization tickets
Projects
Simpler.Grants.gov Product Backlog
Status: Icebox
Milestone
No milestone
Development

No branches or pull requests
4 participants
@daphnegold @widal001 @margaretspring @sumiat