fix(Renderer): enable returning boolean false from props mapping func…

…tion
HHogg · Feb 8, 2018 · a903476 · a903476
1 parent 9e88337
commit a903476
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 1 deletion.
diff --git a/src/renderer.js b/src/renderer.js
@@ -127,7 +127,7 @@ export default class Renderer {
         if (keyValue) {
           return {
             key: keyValue.key || prop,
-            value: keyValue.value || propValue,
+            value: keyValue.hasOwnProperty('value') ? keyValue.value : propValue,
           };
         }
       } else if (typeof this.options.remarkableProps[prop] === 'string') {

diff --git a/test/renderer.test.js b/test/renderer.test.js
@@ -1267,6 +1267,54 @@ Code
               }],
             }]);
           });
+
+          it('boolean value (true)', () => {
+            assertProps(render(`
+
+![](http://google.com "true")
+
+            `, {}, {
+              remarkableProps: {
+                title(value) {
+                  return {
+                    value: value && value.toLowerCase() == 'true',
+                  };
+                }
+              },
+            }), [{
+              children: [{
+                props: {
+                  alt: '',
+                  src: 'http://google.com',
+                  title: true,
+                },
+              }],
+            }]);
+          });
+
+          it('boolean value (false)', () => {
+            assertProps(render(`
+
+![](http://google.com "false")
+
+            `, {}, {
+              remarkableProps: {
+                title(value) {
+                  return {
+                    value: value && value.toLowerCase() == 'true',
+                  };
+                }
+              },
+            }), [{
+              children: [{
+                props: {
+                  alt: '',
+                  src: 'http://google.com',
+                  title: false,
+                },
+              }],
+            }]);
+          });
         });
 
         it('string', () => {