fix(Footnote): Correct output of href/id attrs

Previously we were outputting `#my-id` as the id attribute and `my-id` as the href attribute for footnote references.
HHogg · Jun 1, 2020 · eceabe2 · eceabe2
1 parent 75848a4
commit eceabe2
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/defaultRemarkableProps.js b/src/defaultRemarkableProps.js
@@ -16,10 +16,10 @@ export default {
       case 'footnote_anchor':
         return {
           key: 'href',
-          value: `fn${id}:${token.subId || 0}`,
+          value: `#fn${id}:${token.subId || 0}`,
         };
       case 'footnote_open':
-        return { value: `#fn${id}` };
+        return { value: `fn${id}` };
       case 'footnote_ref':
         return type === 'a' ? ({
           key: 'href',

diff --git a/test/__snapshots__/Renderer.test.js.snap b/test/__snapshots__/Renderer.test.js.snap
@@ -76,12 +76,12 @@ Array [
   <section>
     <ol>
         <li
-            id="#fn0"
+            id="fn0"
         >
             <p>
                 Foonote body
                 <a
-                    href="fn0:0"
+                    href="#fn0:0"
                 >
                     ↩
                 </a>

diff --git a/test/__snapshots__/TokenTree.components.test.js.snap b/test/__snapshots__/TokenTree.components.test.js.snap
@@ -160,7 +160,7 @@ Array [
                   Object {
                     "children": "↩",
                     "props": Object {
-                      "href": "fn0:0",
+                      "href": "#fn0:0",
                     },
                     "type": "a",
                   },
@@ -170,7 +170,7 @@ Array [
               },
             ],
             "props": Object {
-              "id": "#fn0",
+              "id": "fn0",
             },
             "type": "li",
           },
@@ -239,7 +239,7 @@ Array [
               },
             ],
             "props": Object {
-              "id": "#fn0",
+              "id": "fn0",
             },
             "type": "li",
           },