From 8b994a7014db6c72973ded26db4e8bd7e664298f Mon Sep 17 00:00:00 2001
From: Fawad Ali <m.fawaadali98@gmail.com>
Date: Tue, 25 May 2021 01:48:06 +0500
Subject: [PATCH] fix(event-display): fix too many params for hits

---
 .../src/loaders/objects/phoenix-objects.ts           | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/packages/phoenix-event-display/src/loaders/objects/phoenix-objects.ts b/packages/phoenix-event-display/src/loaders/objects/phoenix-objects.ts
index 9a866a481..53fedd256 100644
--- a/packages/phoenix-event-display/src/loaders/objects/phoenix-objects.ts
+++ b/packages/phoenix-event-display/src/loaders/objects/phoenix-objects.ts
@@ -290,7 +290,7 @@ export class PhoenixObjects {
   private static hitsToPoints(
     pointPos: any,
     hitsParams: any,
-    hitParamsClone: any
+    _hitParamsClone: any
   ): Object3D {
     const geometry = new BufferGeometry();
     geometry.setAttribute('position', new BufferAttribute(pointPos, 3));
@@ -302,7 +302,9 @@ export class PhoenixObjects {
     });
     // object
     const pointsObj = new Points(geometry, material);
-    pointsObj.userData = Object.assign({}, hitParamsClone);
+    // Disabling for now because the data isn't readable on object selection.
+    // pointsObj.userData = Object.assign({}, hitParamsClone);
+    pointsObj.userData = {};
     pointsObj.name = 'Hit';
     // Setting uuid for selection from collections info
     hitsParams.uuid = pointsObj.uuid;
@@ -320,7 +322,7 @@ export class PhoenixObjects {
   private static hitsToLines(
     pointPos: any,
     hitsParams: any,
-    hitParamsClone: any
+    _hitParamsClone: any
   ): Object3D {
     // geometry
     const geometry = new BufferGeometry();
@@ -333,7 +335,9 @@ export class PhoenixObjects {
     });
     // object
     const linesObj = new LineSegments(geometry, material);
-    linesObj.userData = Object.assign({}, hitParamsClone);
+    // Disabling for now because the data isn't readable on object selection.
+    // linesObj.userData = Object.assign({}, hitParamsClone);
+    linesObj.userData = {};
     linesObj.name = 'Hit';
     // Setting uuid for selection from collections info
     hitsParams.uuid = linesObj.uuid;