Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new recap #42

Merged
merged 22 commits into from
Feb 15, 2025
Merged

Feat/new recap #42

merged 22 commits into from
Feb 15, 2025

Conversation

winzamark123
Copy link
Contributor

No description provided.

Copy link
Contributor

@JayJ104 JayJ104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. the entire blurred box is not vertically centered in the cloud bg (see pictures 1 and 2)
  2. radio buttons of the carousel are not styled
  3. the secondary frames of the carousel disappear around 400px (see picture 3) probably need to reduce the size of the entire carousel for the smallest tw breakpoint
  4. winners asset should be smaller and align w the top of the carousel. currently it overlaps w the "hackdavis 2024 recap" title below 800px (see picture 4)
  5. padding between "hackdavis 2024 recap" and the carousel/winners components needs to be increased.
  6. "view 2024 winners" button text has a different color on figma. font size should also be bigger on mobile
  7. there's a warning about extra attribute on the console
  8. there should be a greater gap between the carousel and the winners asset once you switch to flex column, check figma.
  9. space from left and right for the entire blurred section does not match the other sections on the page in any screen size (see picture 5)
  10. once you've fixed all this, remind me to ask michelle to fix the archives section. the arrows appear twice in the 640px to 760px range, the last vinyl asset has no space to its right and the edge spacing is also not aligned w the recap component.

image
image
image
image
image

@JayJ104
Copy link
Contributor

JayJ104 commented Feb 11, 2025

also, design may or may not want the functionality of changing carousel frames by clicking on it (ie you click on the right most frame and it comes to the center) OR they may want auto slideshow like last year's pictures. so check w johnson and implement accordingly :)

@JayJ104 JayJ104 linked an issue Feb 11, 2025 that may be closed by this pull request
@JayJ104 JayJ104 merged commit 99e3922 into main Feb 15, 2025
2 checks passed
@JayJ104 JayJ104 deleted the feat/new_recap branch February 15, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

about us: 2024 recap section
2 participants