generated from HackDavis/nextjs-app-router-template
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/new recap #42
Merged
Merged
Feat/new recap #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayJ104
requested changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the entire blurred box is not vertically centered in the cloud bg (see pictures 1 and 2)
- radio buttons of the carousel are not styled
- the secondary frames of the carousel disappear around 400px (see picture 3) probably need to reduce the size of the entire carousel for the smallest tw breakpoint
- winners asset should be smaller and align w the top of the carousel. currently it overlaps w the "hackdavis 2024 recap" title below 800px (see picture 4)
- padding between "hackdavis 2024 recap" and the carousel/winners components needs to be increased.
- "view 2024 winners" button text has a different color on figma. font size should also be bigger on mobile
- there's a warning about extra attribute on the console
- there should be a greater gap between the carousel and the winners asset once you switch to flex column, check figma.
- space from left and right for the entire blurred section does not match the other sections on the page in any screen size (see picture 5)
- once you've fixed all this, remind me to ask michelle to fix the archives section. the arrows appear twice in the 640px to 760px range, the last vinyl asset has no space to its right and the edge spacing is also not aligned w the recap component.
also, design may or may not want the functionality of changing carousel frames by clicking on it (ie you click on the right most frame and it comes to the center) OR they may want auto slideshow like last year's pictures. so check w johnson and implement accordingly :) |
JayJ104
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.