Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic class shoud be reorganized. #513

Open
HajimeKawahara opened this issue Aug 10, 2024 · 3 comments
Open

Atomic class shoud be reorganized. #513

HajimeKawahara opened this issue Aug 10, 2024 · 3 comments
Assignees
Labels
maintenance maintenance, recovers CI, setup, downloading issues etc refactoring refactoring is good

Comments

@HajimeKawahara
Copy link
Owner

I noticed in moldb.py, now there are only atomic databases. We should reorganize Adb classes.

@HajimeKawahara HajimeKawahara added refactoring refactoring is good maintenance maintenance, recovers CI, setup, downloading issues etc labels Aug 10, 2024
@HajimeKawahara HajimeKawahara added this to the v1.6 milestone Aug 10, 2024
@minouHub
Copy link

minouHub commented Aug 20, 2024

Hello,
We have a GSOC working on atomic spectra on the radis side. If you have quick comments to pass before the project is finished, do not hesitate!

EDIT: sorry for the spam, I thought at first your post was linked to RADIS GSOC but it is not!

@HajimeKawahara
Copy link
Owner Author

Hello,
Great! Are these implementations included as a common API? 
radis/radis#558
If so, ExoJAX will use these capabilities instead of the internal I/O.

@minouHub
Copy link

Indeed, the objectives of the GSOC were to implement 2 atomic databases in a new common API. The new databases took more time than expected. Thus, for the moment, NIST and Kurucz will be downloaded as we do for HITRAN, ExoMol, and GEISA... but we are still planing on doing the common API!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance maintenance, recovers CI, setup, downloading issues etc refactoring refactoring is good
Projects
None yet
Development

No branches or pull requests

3 participants