Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64 macOS runner support #461

Closed
zugazagoitia opened this issue Feb 21, 2024 · 6 comments · Fixed by #462 or #463
Closed

aarch64 macOS runner support #461

zugazagoitia opened this issue Feb 21, 2024 · 6 comments · Fixed by #462 or #463

Comments

@zugazagoitia
Copy link

They're now available by using the macos-14 OS in GH Actions.

@Hakky54 Hakky54 linked a pull request Feb 22, 2024 that will close this issue
@Hakky54
Copy link
Owner

Hakky54 commented Feb 22, 2024

Amazing news, thank you for sharing this! I am using macos-latest option so I expect the macos-14 will be automatically used. However I just tried it out forcing a specific version and the performance looks promising with a performance gain of 30% in build time.

By the way, congratulations with merging javalin-ssl with the main repository of javalin. It seems like it got well adopted and accepted!

@zugazagoitia
Copy link
Author

Amazing news, thank you for sharing this! I am using macos-latest option so I expect the macos-14 will be automatically used.

Well, actually.... No. The macos-latest is macos-12: https://github.com/actions/runner-images

By the way, congratulations with merging javalin-ssl with the main repository of javalin. It seems like it got well adopted and accepted!

Thank you! We just moved it so I didn't have to deal with releases on a separate repo, easier to release it as a module.

@zugazagoitia
Copy link
Author

I see you closed it by merging, but I would recommend having both macos-13 and 14, to test against x64 and aarch64 Mac targets.

@Hakky54
Copy link
Owner

Hakky54 commented Feb 22, 2024

Sure, I can adjust that, however what would be the benefit of testing it on two different architectures? Did you faced any issues in the past with this library and javalin or is it just to have a better os/architecture coverage?

@Hakky54 Hakky54 reopened this Feb 22, 2024
@zugazagoitia
Copy link
Author

yes. I did. Conscrypt/bouncycastle do not support aarch64 for example.... I only find out by some issue.
When dealing with crypto stuff, very dependent on the JDK/native implementation, I've found it a good idea to cover arch/os separately.

@Hakky54 Hakky54 linked a pull request Feb 22, 2024 that will close this issue
@Hakky54
Copy link
Owner

Hakky54 commented Feb 22, 2024

Sounds a good reason, I have added it now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants