Skip to content
This repository has been archived by the owner on Nov 27, 2022. It is now read-only.

Refactor with richer data #7

Open
2 tasks
metasoarous opened this issue Mar 19, 2015 · 2 comments
Open
2 tasks

Refactor with richer data #7

metasoarous opened this issue Mar 19, 2015 · 2 comments

Comments

@metasoarous
Copy link
Contributor

This will help support #6.

  • Should be passing maps of data about functions/macros around instead of just qualified names. This gives us more flexibility.
  • Also in general, the processing passes here are not very clean. Would be better to clearly separate a full dependencies parse from all of the downstream filtering, writing, etc.
@Hendekagon
Copy link
Owner

preserving such information would allow for graphs to be coloured & styled to show more information, good idea.

btw I made a graph of your project's internal dependencies only, see the wiki - it's a planar graph!
(scsv/spit-csv "sdeps.csv" (mapcat (fn [[k v]] (map (partial vector k "") (distinct (c/except (filter namespace (remove (partial = k) v)) (c/default-exclude))))) (c/all-deps "src")))

@metasoarous
Copy link
Contributor Author

Awesome; that's great to see :-)

I've got a refactor going which simplifies this a little bit:

(-> (dependencies 'clojure.tools.cli)
    (deps-ns-filter ['clojure.tools.cli\/])
    ((fn [ds] (export-graphviz (nodes ds) (edges ds) "tools.cli"))))

I'll throw a pull request your way soon.

@metasoarous metasoarous mentioned this issue Mar 20, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants