Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't seem to work when task bar at top #70

Closed
jonathanmc opened this issue Feb 28, 2022 · 7 comments
Closed

Doesn't seem to work when task bar at top #70

jonathanmc opened this issue Feb 28, 2022 · 7 comments

Comments

@jonathanmc
Copy link

jonathanmc commented Feb 28, 2022

I know this isn't supported by Windows, but if you move your Windows taskbar to the top of the screen through hack, this drag and drop program does not work, sadly. Otherwise, great program and thank you.

Drag and drop is required, really, and Windows made an error not implementing it, so thank you! (Edit: To be clear, this was meant to be a criticism of Windows, not your program! My original comment made it seem I was criticizing this utility. Nope!)

You can work around by ALT-TAB'g while holding the file, but of course that is more cumbersome.

@HerMajestyDrMona
Copy link
Owner

HerMajestyDrMona commented Feb 28, 2022

I'm not sure if there's much sense in adding support for the custom windows modifications in this program, when the next Windows 11 release will have the drag-and-drop support with it. Of course I understand that some people need these features working right now, but still...

Maybe it would be easier, if people who need to get custom modifications working, modified the code of the program, and then compiled it themselves?

As example:

if ((P_Client.x >= 0 && P_Client.y >= 0 && P_Client.x <= TaskbarWindowWidth) || ShowDesktopPositionNow) {
if (Last_Step_Reached < 4) {
Last_Step_Reached = 4;
}

Here's the code that detects if the mouse is in the taskbar area. However, changing only this wouldn't make much difference, since there's "pixel detection", "thumbnail window" detection and dozen of other functions that depend on the taskbar position. So changing everything to work for the both taskbar positions could be a bit time consuming and require a lot of thinking.

I'm not saying "no", but I'm not very motivated at the moment to focus on such things myself, especially because I don't use it in this position. It would be perfect if somebody who's able to code in C++ and uses the taskbar on top would make such modification, then I would integrate it with the main program in the update.

Anyway, when I have some time I'll be looking at it, but I don't promise anything.

@jonathanmc
Copy link
Author

Appreciate the comments. Just waned to note the issue, and didn't realize drag and drop was to be implemented in Windows updates. In that case, easiest really is to just wait.

Oh, my comment about the feature required referred to Windows, not your program! Cheers and thanks for providing this to fill in their error/missing feature.

@HerMajestyDrMona
Copy link
Owner

Oh, no worries, I understood how the drag-and-drop is needed, for many, many users. I wish I could make it compatible with the other modifications, but sometimes we just need to know if something is worth it.

I am recently a bit stressed about the war in Europe, so it's hard to focus on coding.

@jonathanmc
Copy link
Author

I understand! Do what lowers stress right now. Be very well.

@jonathanmc
Copy link
Author

jonathanmc commented Mar 7, 2022

See my comment here: Naamloos/TopCenterStart11#8 (comment)

If you install this utility, plus that one, drag and drop works to taskbar (when at top).

Thank you to both of you!

@Naamloos
Copy link

Naamloos commented Mar 7, 2022

🙏

@HerMajestyDrMona
Copy link
Owner

HerMajestyDrMona commented Mar 8, 2022

Oh wow, that's great!

I now realized, that the "error" icon (when dragging to the taskbar) is still displayed above the mouse pointer, so it will work when the mouse pointer is in the middle of the taskbar icon, but not when the mouse pointer is too much on the top.
To fix this, you can use the following configuration line:

DetectKnownPixelColorsToPreventAccidentalEvents=0

(it shouldn't be needed that much when the taskbar is on top, because it's useful when selecting text in the opened documents only)

Another problem i detected, is that when AutoOpenFirstWindowInBestMethodEver is set to 1 (to automatically open the first active window, when multiple windows are open under the same icon) it doesn't open it. But that shouldn't be a problem at all, especially when it's not a default option.

It's really cool that it works without any further modifications needed in Windows11DragAndDropToTaskbarFix. I think the main issue was that the preview window was displayed above the screen when the taskbar was on top, therefore function IsWindowVisible was returning FALSE, and the program thought that the icon has no active window.

Even dragging to the "show desktop" button works! I thought it was all depended on screen coordinates / taskbar position, but seems like I made it work in a smarter way :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants