You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We should make the local desktop testing for this project easier. Currently we have to make with the following command locally, unless you clone the project perfectly:
USE_CONTAINER=true GH_USER=HewlettPackard GH_REPO=oneview-golang make test
Lets make using docker to build this project the default, so that requirements will now be:
docker
make
No need to have golang even installed. This should remove the requirement for USE_CONTAINER option, but we should still have the option so that the setting USE_CONTAINER=false is possible under travis builds, where we don't have docker.
If we always build in docker then we can assume that GH_USER can always be HewlettPackard and GH_REPO=oneview-golang can always be oneview-golang. This also improves local testing before submits.
Lets also fix how we call docker to include -e GH_REPO and -e GH_USER in the Makefile.
The text was updated successfully, but these errors were encountered:
We should make the local desktop testing for this project easier. Currently we have to make with the following command locally, unless you clone the project perfectly:
Lets make using docker to build this project the default, so that requirements will now be:
No need to have golang even installed. This should remove the requirement for USE_CONTAINER option, but we should still have the option so that the setting USE_CONTAINER=false is possible under travis builds, where we don't have docker.
If we always build in docker then we can assume that GH_USER can always be
HewlettPackard
and GH_REPO=oneview-golang
can always be oneview-golang. This also improves local testing before submits.Lets also fix how we call docker to include
-e GH_REPO
and-e GH_USER
in the Makefile.The text was updated successfully, but these errors were encountered: