Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing fields and extra fields for enclosure. #156

Merged
merged 2 commits into from
Feb 19, 2019
Merged

Missing fields and extra fields for enclosure. #156

merged 2 commits into from
Feb 19, 2019

Conversation

jyothisgm
Copy link
Collaborator

Description

Bug Fix for
#153
by adding missing fields

Issues Resolved

#153

Check List

  • New functionality includes testing.
    • All tests pass for go 1.11 + gofmt checks.
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
  • Changes are documented in the CHANGELOG.

soodpr
soodpr approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member

@soodpr soodpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sowmyahsg
Sowmyahsg reviewed Feb 19, 2019
View reviewed changes
Copy link
Contributor

@Sowmyahsg Sowmyahsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyothisgm jyothisgm merged commit ab5b782 into master Feb 19, 2019
@jyothisgm jyothisgm deleted the bug/fix/enclosure branch February 19, 2019 10:26
@jyothisgm jyothisgm mentioned this pull request Feb 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sowmyahsg Sowmyahsg Sowmyahsg left review comments

@madhav-bharadwaj madhav-bharadwaj madhav-bharadwaj approved these changes

@soodpr soodpr soodpr approved these changes

@AnushaY1916 AnushaY1916 Awaiting requested review from AnushaY1916

@supreethpy supreethpy Awaiting requested review from supreethpy

@dileepds dileepds Awaiting requested review from dileepds

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jyothisgm @madhav-bharadwaj @soodpr @Sowmyahsg