Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difficulty when extending Tango #9

Open
cyruscyliu opened this issue Aug 7, 2024 · 0 comments
Open

Difficulty when extending Tango #9

cyruscyliu opened this issue Aug 7, 2024 · 0 comments
Labels
skill It's a skill issue

Comments

@cyruscyliu
Copy link
Collaborator

cyruscyliu commented Aug 7, 2024

First things first, to understand Tango

  1. There are too many components to remember.
  2. After two days of not looking at the code space, you forget everything.
  3. Flexibility -> Complexity. The class inheritance relationship is too complicated: diamond inheritance, many empty classes, and too many callbacks.
  4. Unable to refactor due to the lack of tests.
  5. Some functionalities are fancy, but nothing is related to the main logic.
  6. Tango’s initial check of states is way too strict. A full snapshot is better?
@hazimeh hazimeh added the skill It's a skill issue label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skill It's a skill issue
Projects
None yet
Development

No branches or pull requests

2 participants