Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display images in full-text RSS feed #45

Closed
sarah11918 opened this issue May 11, 2024 · 2 comments · Fixed by #94
Closed

Display images in full-text RSS feed #45

sarah11918 opened this issue May 11, 2024 · 2 comments · Fixed by #94
Labels
bug Something isn't working upstream Issues that need to be addressed upstream in Starlight, Astro or another library

Comments

@sarah11918
Copy link
Contributor

Is your feature request related to a problem?

Sort of!

The RSS feed shows full-text in my feed reader (The Old Reader), but the images do not display. Instead, the alt-text is displayed.

image

Describe the solution you'd like

I would love it if the full text of my RSS feeds displayed any included images.

Describe alternatives you've considered

I have not tested other feed readers besides The Old Reader so I don't know how common this issue is among feed readers/client.

Additional Context

No response

@HiDeoo
Copy link
Owner

HiDeoo commented May 11, 2024

v0.8.1 includes a workaround for this issue by replacing images with a placeholder and a link to the original post containing the image.

I'm keeping this issue opened as I cannot properly fix it until some upstream changes are released, specifically thinking about the Astro Container API, and I definitely want to revisit this issue once it's possible to do so.

@HiDeoo HiDeoo added bug Something isn't working upstream Issues that need to be addressed upstream in Starlight, Astro or another library labels May 11, 2024
@scottaw66
Copy link

scottaw66 commented May 25, 2024

If you're using sanitizeHtml, make sure to tell it to include the img tag. If not, please feel free to delete this comment.

CleanShot 2024-05-25 at 16 09 25@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream Issues that need to be addressed upstream in Starlight, Astro or another library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants