Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting page ID starting from digit #195

Open
alexbk66 opened this issue Apr 24, 2021 · 5 comments
Open

Setting page ID starting from digit #195

alexbk66 opened this issue Apr 24, 2021 · 5 comments
Assignees
Labels
Documentation Improvements or additions to documentation HS Core This issue involves changes to core HS systems. NOT FOR PLUGINS Jira This issue has been linked to a Jira issue To Do This issue is in need of attention

Comments

@alexbk66
Copy link

alexbk66 commented Apr 24, 2021

If I register a setting page with ID starting from digit - when I click on the name - page doesn't show (I'm using name=id):

image

@alexbk66 alexbk66 changed the title Setting page name starting from digit Setting page ID starting from digit Apr 24, 2021
@spudwebb
Copy link
Collaborator

It looks like this is a html thing you can't have a html id starting with a number
https://stackoverflow.com/questions/45617692/bootstrap-4-tabs-not-switching-content-when-leading-number-is-used-in-tab-id

@alexbk66
Copy link
Author

[id='1800number_box'] {
/* does work */
}

@spudwebb
Copy link
Collaborator

it's the bootstrap code that needs to be fixed for this to work: twbs/bootstrap#31099
so we will update the docs to tell developers to not use ids that start with a digit. PSDK-160

@spudwebb spudwebb added the Documentation Improvements or additions to documentation label May 28, 2021
@pierresouchay
Copy link

Probably fixed by twbs/bootstrap#35566

@spudwebb spudwebb added the Jira This issue has been linked to a Jira issue label Jan 18, 2022
@jldubz
Copy link
Collaborator

jldubz commented Mar 7, 2022

Probably fixed by twbs/bootstrap#35566

Sounds like we need to update bootstrap in the core. Thanks for pointing this out. Tracking the update of bootstrap in HS-1593

@jldubz jldubz added HS Core This issue involves changes to core HS systems. NOT FOR PLUGINS To Do This issue is in need of attention and removed Feedback labels Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation HS Core This issue involves changes to core HS systems. NOT FOR PLUGINS Jira This issue has been linked to a Jira issue To Do This issue is in need of attention
Projects
None yet
Development

No branches or pull requests

5 participants