From e09eaf5b3144983b792ff71167274f8da2cd356c Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Thu, 7 Feb 2019 21:13:13 +0100 Subject: [PATCH] Only use `sudo` if it is actually needed. --- Library/Homebrew/cask/artifact/moved.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cask/artifact/moved.rb b/Library/Homebrew/cask/artifact/moved.rb index e7d8d24847cee..67b0ca2e5a014 100644 --- a/Library/Homebrew/cask/artifact/moved.rb +++ b/Library/Homebrew/cask/artifact/moved.rb @@ -40,13 +40,13 @@ def move(force: false, command: nil, **options) end ohai "Moving #{self.class.english_name} '#{source.basename}' to '#{target}'." - if target.dirname.parent.writable? + if target.dirname.ascend.find(&:directory?).writable? target.dirname.mkpath else command.run!("/bin/mkdir", args: ["-p", target.dirname], sudo: true) end - if target.parent.writable? + if target.dirname.writable? FileUtils.move(source, target) else command.run!("/bin/mv", args: [source, target], sudo: true)