From 3e11f315f7167541cf2a6e552d3fe23e4ef64e32 Mon Sep 17 00:00:00 2001 From: Bevan Kay Date: Wed, 28 Dec 2022 15:18:59 +1100 Subject: [PATCH 1/3] cask/audit: improve sparkle minimum version audit --- Library/Homebrew/cask/audit.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/cask/audit.rb b/Library/Homebrew/cask/audit.rb index 69479bd12f59c..ef237753ae18e 100644 --- a/Library/Homebrew/cask/audit.rb +++ b/Library/Homebrew/cask/audit.rb @@ -583,7 +583,7 @@ def check_livecheck_min_os return if cask_min_os == min_os_string add_error "Upstream defined #{min_os_string.to_sym.inspect} as minimal OS version " \ - "and the cask defined #{cask_min_os.to_sym.inspect}" + "and the cask defined #{cask_min_os ? cask_min_.to_sym.inspect : "no minimal OS version"}." end sig { void } From 2788efb732350367b87c02d649540f9b170487cc Mon Sep 17 00:00:00 2001 From: Bevan Kay Date: Wed, 28 Dec 2022 16:26:45 +1100 Subject: [PATCH 2/3] Update audit.rb --- Library/Homebrew/cask/audit.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/cask/audit.rb b/Library/Homebrew/cask/audit.rb index ef237753ae18e..187b0f3d0c977 100644 --- a/Library/Homebrew/cask/audit.rb +++ b/Library/Homebrew/cask/audit.rb @@ -582,8 +582,9 @@ def check_livecheck_min_os return if cask_min_os == min_os_string + min_os_symbol = cask_min_os&.to_sym.inspect || "no minimal OS version" add_error "Upstream defined #{min_os_string.to_sym.inspect} as minimal OS version " \ - "and the cask defined #{cask_min_os ? cask_min_.to_sym.inspect : "no minimal OS version"}." + "and the cask defined #{min_os_symbol}." end sig { void } From c45a32ea8d289d6d078cdf8568767fcea8336423 Mon Sep 17 00:00:00 2001 From: Bevan Kay Date: Wed, 28 Dec 2022 16:32:58 +1100 Subject: [PATCH 3/3] Update Library/Homebrew/cask/audit.rb Co-authored-by: Rylan Polster --- Library/Homebrew/cask/audit.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/cask/audit.rb b/Library/Homebrew/cask/audit.rb index 187b0f3d0c977..bcf8d65f39f0e 100644 --- a/Library/Homebrew/cask/audit.rb +++ b/Library/Homebrew/cask/audit.rb @@ -584,7 +584,7 @@ def check_livecheck_min_os min_os_symbol = cask_min_os&.to_sym.inspect || "no minimal OS version" add_error "Upstream defined #{min_os_string.to_sym.inspect} as minimal OS version " \ - "and the cask defined #{min_os_symbol}." + "and the cask defined #{min_os_symbol}" end sig { void }