Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew search should be aware of cask suffix name stripping conventions #13028

Closed
jsoref opened this issue Mar 22, 2022 · 4 comments
Closed

brew search should be aware of cask suffix name stripping conventions #13028

jsoref opened this issue Mar 22, 2022 · 4 comments
Labels
features New features help wanted We want help addressing this outdated PR was locked due to age

Comments

@jsoref
Copy link
Contributor

jsoref commented Mar 22, 2022

Provide a detailed description of the proposed feature

brew search should automatically remove any of the suffixes that are supposed to be removed by packagers per https://docs.brew.sh/Cask-Cookbook#token-reference

What is the motivation for the feature?

Due to brew's cask package naming conventions: https://docs.brew.sh/Cask-Cookbook#token-reference,
Desktop and similar are supposed to be stripped from the end of packages.

Unfortunately, not all brew users know/understand these conventions, which means it isn't unusual for a user to hear about rancher-desktop, and then try brew search rancher-desktop, when they do, they get results like this:

% brew search rancher-desktop
==> Formulae
rancher-compose
% brew search docker-desktop
==> Formulae
docker-ls

How will the feature be relevant to at least 90% of Homebrew users?

Users will be able to do searches for products by the familiar name for the product and easily find the respective brew cask for it.

What alternatives to the feature have been considered?

  1. Asking to undo the https://docs.brew.sh/Cask-Cookbook#token-reference policy (this wasn't a serious consideration)
  2. Provide some way for casks to define aliases for searching (I'm not terribly opposed to this approach, but it seems better to have brew search do the work than force each cask author to do it).
@jsoref jsoref added the features New features label Mar 22, 2022
@MikeMcQuaid MikeMcQuaid added the help wanted We want help addressing this label Mar 24, 2022
@rotu
Copy link

rotu commented Apr 25, 2022

Is it in this scope to remove homebrew and casks tap names from search matching?

As it is, brew search home will bring up every formula instead of just legitimate matches like home-assistant. Same with brew search cas finding all casks instead of e.g. yacas.

@jandubois
Copy link

Is it in this scope to remove homebrew and casks from search terms?

I think that is a separate problem that should have it's own Github issue.

@rotu
Copy link

rotu commented Apr 25, 2022

I think that is a separate problem that should have it's own Github issue.

Roger. #13193

@MikeMcQuaid
Copy link
Member

Partially addressed in #13048

@github-actions github-actions bot added the outdated PR was locked due to age label Jul 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
features New features help wanted We want help addressing this outdated PR was locked due to age
Projects
None yet
Development

No branches or pull requests

4 participants