Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check macos version before download #72474

Closed
brandonkal opened this issue Nov 12, 2019 · 4 comments · Fixed by Homebrew/brew#8572
Closed

Check macos version before download #72474

brandonkal opened this issue Nov 12, 2019 · 4 comments · Fixed by Homebrew/brew#8572
Labels
core Issue with Homebrew itself rather than with a specific cask. enhancement outdated ready to implement

Comments

@brandonkal
Copy link
Contributor

Description of feature/enhancement

Having an app download and then not be installed because of a depends_on clause that specifies a different OS version is not the best experience. Ideally, Homebrew should validate the OS version requirements first before attempting to download a cask.

Justification

See above

Example use case

See the calibre cask. The dmg is downloaded on my slow connection and then home-brew reports that mojave is required. The experience could be worse for larger applications.

@grantfar
Copy link

I will take this

@vitorgalvao
Copy link
Contributor

Thank you, @grantfar. We’ll be awaiting the PR. If you have any specific questions, let us know.

@Akylzhan
Copy link
Contributor

Akylzhan commented Sep 2, 2020

@vitorgalvao I was thinking about this problem a bit
What if we will change the order in installer.rb to this:

satisfy_dependencies
verify_has_sha if require_sha? && !force?
download
verify

@vitorgalvao
Copy link
Contributor

It probably should be above just above download, but yes, that seems like it might work.

@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core Issue with Homebrew itself rather than with a specific cask. enhancement outdated ready to implement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants