Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvino: added telemetry support #168326

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

ilya-lavrenov
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@ilya-lavrenov ilya-lavrenov force-pushed the openvino-telemetry branch 3 times, most recently from 4c01c3c to 570156f Compare April 8, 2024 15:09
@chenrui333
Copy link
Member

Errno::ENOTEMPTY: Directory not empty @ dir_s_rmdir - /private/tmp/homebrew-unpack20240408-6500-fit0gj

@chenrui333 chenrui333 added the build failure CI fails while building the software label Apr 18, 2024
@ilya-lavrenov
Copy link
Contributor Author

Errno::ENOTEMPTY: Directory not empty @ dir_s_rmdir - /private/tmp/homebrew-unpack20240408-6500-fit0gj

I don't understand what does it mean. Could you please advice what I'm doing wrong?
I have not found good example in existing brew formulas, where C++ extension is built and other python packages (like packaging) are used

@chenrui333
Copy link
Member

Errno::ENOTEMPTY: Directory not empty @ dir_s_rmdir - /private/tmp/homebrew-unpack20240408-6500-fit0gj

I don't understand what does it mean. Could you please advice what I'm doing wrong? I have not found good example in existing brew formulas, where C++ extension is built and other python packages (like packaging) are used

yeah, not quite sure what happened, gonna rebase and kick a new run.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label May 20, 2024
@ilya-lavrenov
Copy link
Contributor Author

I need help here, because I don't know how to add extra python packages to OpenVINO Python API

@p-linnane p-linnane closed this Jun 7, 2024
@branchvincent branchvincent reopened this Jun 24, 2024
@branchvincent branchvincent force-pushed the openvino-telemetry branch 2 times, most recently from a30b76c to 7b365c1 Compare June 24, 2024 02:59
@branchvincent branchvincent removed stale No recent activity build failure CI fails while building the software labels Jun 24, 2024
@p-linnane p-linnane force-pushed the openvino-telemetry branch from 7b365c1 to 5e43eee Compare June 24, 2024 05:33
@p-linnane p-linnane requested a review from branchvincent June 24, 2024 06:23
@ilya-lavrenov
Copy link
Contributor Author

Looks like OpenVINO has been built, thank you @p-linnane and @branchvincent
Do we need extra labels to pass OpenCV tests? long-run or something similar?

@bevanjkay bevanjkay added the long dependent tests Set a long timeout for dependent testing label Jun 24, 2024
@ilya-lavrenov ilya-lavrenov requested a review from jaraco June 24, 2024 10:41
@branchvincent
Copy link
Member

Needs #175545 first, then we should be good

@branchvincent branchvincent added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Jun 25, 2024
Copy link

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jun 25, 2024
@branchvincent
Copy link
Member

thanks so much @ilya-lavrenov! sorry this took so long, and thank you @jaraco for your bug report and review here

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jun 26, 2024
@BrewTestBot BrewTestBot enabled auto-merge June 26, 2024 02:01
@BrewTestBot BrewTestBot added this pull request to the merge queue Jun 26, 2024
Merged via the queue into Homebrew:master with commit 3a3cfcf Jun 26, 2024
13 of 14 checks passed
@ilya-lavrenov ilya-lavrenov deleted the openvino-telemetry branch June 26, 2024 08:55
@chenrui333 chenrui333 removed the CI-requeued PR has been re-added to the queue label Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long dependent tests Set a long timeout for dependent testing ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants