Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer: remove bottle :unneeded #75973

Closed
wants to merge 1 commit into from

Conversation

Amar1729
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

See #75943

@nandahkrishna nandahkrishna added CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. do not merge labels Apr 26, 2021
@Amar1729
Copy link
Contributor Author

> sha256sum *.tar.gz

5c57fc24e730c474ef5431a702b2a38cdbb39edbac9aa5869e163226172dc526  composer--2.0.12.arm64_big_sur.bottle.tar.gz
c477095403f8ea044a721282e8ebbb76557c52a1e3b75bd1a5552ed99a6f46fe  composer--2.0.12.big_sur.bottle.tar.gz
c477095403f8ea044a721282e8ebbb76557c52a1e3b75bd1a5552ed99a6f46fe  composer--2.0.12.catalina.bottle.tar.gz
a9fe04d8a2219b65c27e4e239d0133cbbb0ebd78564dc9c641085d38468a040c  composer--2.0.12.mojave.bottle.tar.gz

unpacked x86 big sur/mojave bottles don't differ.

> diff -r composer--2.0.12.arm64_big_sur.bottle composer--2.0.12.big_sur.bottle

Binary files composer--2.0.12.arm64_big_sur.bottle/composer/2.0.12/bin/composer and composer--2.0.12.big_sur.bottle/composer/2.0.12/bin/composer differ

> grep -a "PREFIX" composer--2.0.12.big_sur.bottle/composer/2.0.12/bin/composer                     

'@@HOMEBREW_PREFIX@@/share/certs/ca-root-nss.crt',
'@@HOMEBREW_PREFIX@@/share/curl/curl-ca-bundle.crt',
'@@HOMEBREW_PREFIX@@/etc/ssl/cert.pem',
'@@HOMEBREW_PREFIX@@/etc/openssl/cert.pem',
'@@HOMEBREW_PREFIX@@/etc/[email protected]/cert.pem',

> grep -a "PREFIX" composer--2.0.12.arm64_big_sur.bottle/composer/2.0.12/bin/composer

(no results)

>

@carlocab
Copy link
Member

Rebased to pull in changes from #76020.

@Amar1729
Copy link
Contributor Author

After rebuild:

> sha256sum *.tar.gz

dc169158657b27b6aa567165b59307fed32154d81cea584ea321e1fabb328503  composer--2.0.13.arm64_big_sur.bottle.tar.gz
4ba039c3ef483e8828ba7a65353e6af28da49227305566d9619ff58ba96ac281  composer--2.0.13.big_sur.bottle.tar.gz
4ba039c3ef483e8828ba7a65353e6af28da49227305566d9619ff58ba96ac281  composer--2.0.13.catalina.bottle.tar.gz
4ba039c3ef483e8828ba7a65353e6af28da49227305566d9619ff58ba96ac281  composer--2.0.13.mojave.bottle.tar.gz

@nandahkrishna
Copy link
Member

Like phpstan, we won't be able to inreplace here as phar files are signed. (#76044 (comment))

@chenrui333 chenrui333 added the bottle-up-everything Make every formula bottled label May 3, 2021
@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label May 25, 2021
@github-actions github-actions bot closed this Jun 1, 2021
@chenrui333 chenrui333 added the php PHP use is a significant feature of the PR or issue label Jun 9, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Jul 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2021
@Amar1729 Amar1729 deleted the bottle/composer branch September 11, 2023 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle-up-everything Make every formula bottled CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. outdated PR was locked due to age php PHP use is a significant feature of the PR or issue stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants