Skip to content
This repository was archived by the owner on Jan 16, 2025. It is now read-only.

Growl and homebrew #8680

Closed
ColinHebert opened this issue Nov 19, 2011 · 3 comments
Closed

Growl and homebrew #8680

ColinHebert opened this issue Nov 19, 2011 · 3 comments

Comments

@ColinHebert
Copy link
Contributor

Hello,

I'm currently working on Growl integration in homebrew (#8649) and I have a few questions.

First, I looked at the current packages related to growl, there is three of them :
growlnotify, a tool used to create growl notification from the command line. Here, it's a binary file copied in /bin (which is downloadable from growl.info) instead of the source files (available on the growl repository).
growly, a tool used to create growl notifications from another command result, in command line. Depends on growly and actually one-page bash script used as a wrapper for growlnotify.
growlme, a tool used to create growl notifications from another command result, in command line. This time it doesn't depends on growly but it's still a one-page script (in python).

I have strictly nothing personal against these packages, but do they have their place in homebrew ?

On the other hand, I was considering to add HardwareGrowler which is an official extra for growl, only available from app store ($2~) but still open-source.

So here is the thing, for HardwareGrowler, should I create a formula, or should I just add a new option the the current growl formula (#8649) ?
Regarding growlnotify, I agree that it's easier to install it from brew but in this case, downloading the actual source code and compiling it would be better. Should I update the growlnotify formula to do so ? Or should I add another option to the growl formula to install at the same time growlnotify (which is worthless without growl). Or should it be simply removed ?

Regarding growly and growlme, should they stay there ? Note that growly depends on growlnotify, so if it has to stay, growlnotify has to stay on a separated formula.

@Sharpie
Copy link
Contributor

Sharpie commented Nov 19, 2011

I think growlnotify could be rolled into your growl formula since it appears to be an 'official' add-on and gives growl a command-line component.

growly can probably stay because it has a versioned release and honestly, the command line arguments to growlnotify are a bit overcomplicated.

growlme may be questionable because it is just a HEAD-only formula---which we frown upon in general.

@ColinHebert
Copy link
Contributor Author

That seems reasonable.

I'll then replace the depends_on "growlnotify" with depends_on "growl".

@ColinHebert
Copy link
Contributor Author

Changes done in #8649

@Homebrew Homebrew locked and limited conversation to collaborators Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants