Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Origin metrics for request cancellations count all requests #199

Closed
kvosper opened this issue Jul 2, 2018 · 1 comment
Closed

Origin metrics for request cancellations count all requests #199

kvosper opened this issue Jul 2, 2018 · 1 comment
Assignees
@mikkokar
Labels
bug styx-0.7

Comments

@kvosper
Copy link
Contributor

kvosper commented Jul 2, 2018 •
edited
Loading

The problem

The metric <prefix>.origins.<origin-id>.requests.cancelled.count counts all requests, not just cancelled requests.

Detailed description

StyxHttpClient assumes that any unsubscription is a cancellation and updates the origin cancellation metrics accordingly.

In reality, RxJava calls unsubscribe whenever an observable terminates.

We need a way to allow StyxHttpClient to distinguish cancellations from other situations.

Acceptance criteria

  • Unsubscriptions that are part of the normal flow should not be recorded as cancellations
  • Real cancellations should still be recorded
@kvosper kvosper changed the title StyxHttpClient counts request completions as cancellations Origin metrics for request cancellations count all requests Jul 3, 2018
@kvosper kvosper self-assigned this Jul 3, 2018
@mikkokar mikkokar assigned mikkokar and unassigned kvosper Jul 10, 2018
mikkokar added a commit to mikkokar/styx that referenced this issue Jul 10, 2018
@mikkokar
Fix issue ExpediaGroup#199: Request cancellation per origin metric.
6c7a536
@mikkokar mikkokar mentioned this issue Jul 10, 2018
Merged
mikkokar added a commit that referenced this issue Jul 10, 2018
@mikkokar
Fix issue #199: origins.ID.requests.cancelled metric. (#209)
4123874
mikkokar added a commit to mikkokar/styx that referenced this issue Jul 10, 2018
@mikkokar
Fix issue ExpediaGroup#199: origins.ID.requests.cancelled metric. (Ex…
5cf9283 
…pediaGroup#209)

(cherry picked from commit 4123874)
mikkokar added a commit to mikkokar/styx that referenced this issue Jul 10, 2018
@mikkokar
Fix issue ExpediaGroup#199: origins.ID.requests.cancelled metric. (Ex…
bfbd4b2 
…pediaGroup#209)

(cherry picked from commit 4123874)
mikkokar added a commit that referenced this issue Jul 10, 2018
@mikkokar
Fix issue #199: origins.ID.requests.cancelled metric. (#209) (#210)
6d62753 
(cherry picked from commit 4123874)
@mikkokar
Copy link
Contributor

Merged to both master and styx-1.0-dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkokar mikkokar

Labels
bug styx-0.7
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikkokar @kvosper