Added support for Kotlin compiler. #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fic sub-projects that want to include Kotlin should declare the dependency kotlin-stdlib-jdk8 (and kotlin-test if needed) and the kotlin-maven-plugin plugin.
kvosper
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for Kotlin compiler in the parent pom 'management' blocks.
Specific sub-projects that want to include Kotlin should declare the dependency kotlin-stdlib-jdk8 (and kotlin-test if needed) and the kotlin-maven-plugin plugin.
We should consider adding nullability annotations to the Java code so we can have null-safe Kotlin even if most of our code base is in Java. See: https://nklmish.wordpress.com/2017/11/01/null-safety-calling-java-from-kotlin/, https://kotlinlang.org/docs/reference/java-interop.html#nullability-annotations . I would go for setting "Not Null by default" and then specifically annotate with @nullable when needed.
In Java we could use these annotations to generate non null checks in runtime (as Kotlin does) via using this tool: http://traute.oss.harmonysoft.tech/