Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused cancel method from HttpTransaction interface #305

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Remove unused cancel method from HttpTransaction interface #305

merged 1 commit into from
Oct 8, 2018

Conversation

mikkokar
Copy link
Contributor

@mikkokar mikkokar commented Oct 8, 2018

The HttpTransaction.cancel method is never used. So remove it. Also remove it from the implementing Transport class.

@mikkokar mikkokar merged commit ab09785 into ExpediaGroup:master Oct 8, 2018
@mikkokar mikkokar deleted the remove-unused-cancel branch April 1, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvlato dvlato dvlato approved these changes

@kvosper kvosper Awaiting requested review from kvosper

@VivianLopes VivianLopes Awaiting requested review from VivianLopes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikkokar @dvlato