Reject requests using the CONNECT method ( Fixes #312) #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| builder.add(new ViaHeaderAppendingInterceptor()); | ||
| builder.add(new HopByHopHeadersRemovingInterceptor()); | ||
| builder.add(new RequestEnrichingInterceptor(config.styxHeaderConfig())); | ||
| builder.add(new TcpTunnelRequestRejector()). |
There was a problem hiding this comment.
it seems that you use different convention with the dot at the end instead of at the front
mikkokar
suggested changes
Oct 25, 2018
| } | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Overall this is what needs to be done. However please follow styx coding standards, specifically use static imports with METHOD_NOT_ALLOWED, and CONNECT. Also I would remove the extra empty lines.
| it("Should reject CONNECT requests") { | ||
| val request = get("/connectTest") | ||
| .addHeader(HOST, styxServer.proxyHost) | ||
| .method(HttpMethod.CONNECT) |
There was a problem hiding this comment.
Static import if possible.
mikkokar
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.