Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated request-logging.enabled option. #347

Merged
merged 1 commit into from
Nov 19, 2018
Merged

Remove deprecated request-logging.enabled option. #347

merged 1 commit into from
Nov 19, 2018

Conversation

mikkokar
Copy link
Contributor

The request-logging.enabled is unnecessary relic from the past.

The correct way to enable minimal request logging in styx is:

request-logging:
  inbound:
    enabled: true

This pull request updates the documentation, and removes any code referring to the request-logging.enabled.

@mikkokar mikkokar requested review from kvosper and dvlato November 19, 2018 10:49
@mikkokar mikkokar merged commit dc03c90 into ExpediaGroup:master Nov 19, 2018
@mikkokar mikkokar deleted the docs-logging branch November 19, 2018 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvosper kvosper kvosper approved these changes

@dvlato dvlato dvlato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikkokar @kvosper @dvlato