Validate http routing object configuration. #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkokar
requested review from
dvlato and
kvosper
and removed request for
dvlato
dvlato
approved these changes
Apr 25, 2019
components/common/src/main/java/com/hotels/styx/config/schema/Schema.java
Show resolved
Hide resolved
|
|
||
| private Optional<String> message(List<String> parents, JsonNode tree) { | ||
| String fullName = Joiner.on(".").join(parents); | ||
| return Optional.of(format("Unexpected field type. Field '%s' should be MAP ('%s'), but it is %s", fullName, this.elementType().describe(), tree.getNodeType())); |
There was a problem hiding this comment.
*Here why I decided to add the comment to remove hardcoded strings for the field type. Still a minor issue of course...
There was a problem hiding this comment.
The element type can be anything. Even a nested map. For this reason the describe() is really important. If I understood your comment correctly? :-)
kvosper
suggested changes
Apr 25, 2019
components/common/src/main/java/com/hotels/styx/config/schema/Schema.java
Outdated
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/config/schema/Schema.java
Outdated
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/config/schema/Schema.java
Outdated
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/config/schema/Schema.java
Outdated
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/config/schema/Schema.java
Outdated
Show resolved
Hide resolved
components/common/src/test/java/com/hotels/styx/config/validator/DocumentFormatTest.java
Outdated
Show resolved
Hide resolved
components/common/src/test/java/com/hotels/styx/config/validator/DocumentFormatTest.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/ServerConfigSchema.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/routing/config/RoutingObjectFactory.java
Outdated
Show resolved
Hide resolved
components/proxy/src/test/kotlin/com/hotels/styx/ServerConfigSchemaTest.kt
Outdated
Show resolved
Hide resolved
mikkokar
force-pushed
the
refactor-styx-routing3
branch
from
66fa1f5 to
a251d3b
Compare
…res. Move unit tests from DocumentFormatTest into SchemaTest.
kvosper
suggested changes
Apr 29, 2019
components/common/src/main/java/com/hotels/styx/config/schema/Schema.java
Outdated
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/config/schema/Schema.java
Outdated
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/config/schema/Schema.java
Outdated
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/config/schema/Schema.java
Outdated
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/config/schema/SchemaDsl.java
Show resolved
Hide resolved
components/common/src/main/java/com/hotels/styx/config/validator/DocumentFormat.java
Outdated
Show resolved
Hide resolved
components/common/src/test/java/com/hotels/styx/config/schema/SchemaTest.java
Show resolved
Hide resolved
components/common/src/test/java/com/hotels/styx/config/schema/SchemaTest.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/ServerConfigSchema.java
Outdated
Show resolved
Hide resolved
components/proxy/src/main/java/com/hotels/styx/routing/config/RoutingObjectFactory.java
Show resolved
Hide resolved
kvosper
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add capability to validate built-in HTTP routing object configurations.
Refactor config schema validator.