Add insert/remove/watch functionality to Object Store #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add watch() method. - Use persistent immutable data structures.
Emit current state at watch subscription.
Restrict visibility.
Tidy up code.
kvosper
suggested changes
Apr 29, 2019
components/proxy/src/main/kotlin/com/hotels/styx/routing/db/StyxObjectStore.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/main/kotlin/com/hotels/styx/routing/db/StyxObjectStore.kt
Show resolved
Hide resolved
components/proxy/src/main/kotlin/com/hotels/styx/routing/db/StyxObjectStore.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/test/kotlin/com/hotels/styx/routing/db/StyxObjectStoreTest.kt
Outdated
Show resolved
Hide resolved
dvlato
reviewed
Apr 29, 2019
components/proxy/src/main/kotlin/com/hotels/styx/routing/db/StyxObjectStore.kt
Show resolved
Hide resolved
components/proxy/src/main/kotlin/com/hotels/styx/routing/db/StyxObjectStore.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/main/kotlin/com/hotels/styx/routing/db/StyxObjectStore.kt
Outdated
Show resolved
Hide resolved
kvosper
suggested changes
Apr 30, 2019
components/proxy/src/main/kotlin/com/hotels/styx/routing/db/StyxObjectStore.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/test/kotlin/com/hotels/styx/routing/db/StyxObjectStoreTest.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/test/kotlin/com/hotels/styx/routing/db/StyxObjectStoreTest.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/test/kotlin/com/hotels/styx/routing/db/StyxObjectStoreTest.kt
Outdated
Show resolved
Hide resolved
components/proxy/src/test/kotlin/com/hotels/styx/routing/db/StyxObjectStoreTest.kt
Outdated
Show resolved
Hide resolved
dvlato
approved these changes
Apr 30, 2019
dvlato
reviewed
Apr 30, 2019
components/proxy/src/main/kotlin/com/hotels/styx/routing/db/StyxObjectStore.kt
Outdated
Show resolved
Hide resolved
kvosper
suggested changes
Apr 30, 2019
components/api/src/main/java/com/hotels/styx/api/configuration/ObjectStore.java
Outdated
Show resolved
Hide resolved
components/api/src/main/java/com/hotels/styx/api/configuration/ObjectStore.java
Outdated
Show resolved
Hide resolved
kvosper
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Object Store functionality for
Concurrency issues:
Watching for Changes:
Consumers can listen for database changes by calling a
watchmethod. It supports watching for the full database only. Watching for individual objects will be implemented in future when necessary.A
watchreturns a reactive streamsPublisher. When subscribed, the publisher emits the current object store snapshot, followed by a new snapshot every time database changes. The publisher keeps emitting the change events in perpetuity until unsubscribed.