Configurable docker base image version. #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvlato
reviewed
Jul 4, 2019
docker/Dockerfile
Outdated
| @@ -1,4 +1,5 @@ | |||
| FROM openjdk:11-jre-slim | |||
| ARG TAG=11-jre-slim | |||
There was a problem hiding this comment.
Do we want to use jre by default? Bundling the JDK tools might prove useful in several environments.
There was a problem hiding this comment.
I am not opinionated about this. My intention was to default on the "production" image. What do you think?
There was a problem hiding this comment.
I have changed to JDK version. Please have another look.
dvlato
approved these changes
Jul 4, 2019
kvosper
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a build time parameter to choose a Docker base image tag.
This allows to choose between the JRE only (default) base, and full JDK that has
jps,jcmd& other tools handy for development purposes.