Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TestNG and replace with junit 5 #514

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Remove TestNG and replace with junit 5 #514

merged 2 commits into from
Nov 5, 2019

Conversation

OwenLindsell
Copy link
Contributor

@OwenLindsell OwenLindsell commented Nov 4, 2019 •
edited
Loading

  1. Removed TestNG and replaced with JUnit 5. Primarily this involved the following steps:
  • Replaced @test(expectedExeption=NullPointerException.class) with inline code assertThrows(NullPointerException.class, () ->
  • Replaced @dataProvider with @ParameterizedTest (
  1. Upgraded Hamcrest: 1.3 -> 2.2

mikkokar
mikkokar approved these changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@mikkokar mikkokar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but left one little comment.

@OwenLindsell OwenLindsell merged commit 7760578 into ExpediaGroup:master Nov 5, 2019
@OwenLindsell OwenLindsell deleted the upgrade-to-junit-5 branch December 5, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikkokar mikkokar mikkokar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OwenLindsell @mikkokar