Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect origin metrics in routing object mode #536

Closed
mikkokar opened this issue Nov 20, 2019 · 1 comment
Closed

Incorrect origin metrics in routing object mode #536

mikkokar opened this issue Nov 20, 2019 · 1 comment
Assignees
@mikkokar

Comments

@mikkokar
Copy link
Contributor

Origin metric paths are incorrectly constructed when YamlFileConfigurationService is used to configure styx from origins file.

The APP.ORIGIN hierarchy repeats twice, resulting names like these:

origins.APP.ORIGIN.APP.ORIGIN.connectionspool.available-connections

The correct metric path should be:

origins.APP.ORIGIN.connectionspool.available-connections
@mikkokar mikkokar self-assigned this Nov 26, 2019
@mikkokar mikkokar mentioned this issue Nov 29, 2019
Merged
mikkokar added a commit that referenced this issue Nov 29, 2019
@mikkokar
Fixes Issue: #536: Duplicated origin ID in metrics name (#545)
57ca491
@bestokes
Copy link

bestokes commented Feb 5, 2020

This is resolved.

@bestokes bestokes closed this as completed Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikkokar mikkokar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bestokes @mikkokar