Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do I specify tzdb location on Windows for the vcpkg port #541

Open
bangusi opened this issue Jan 27, 2020 · 6 comments
Open

How do I specify tzdb location on Windows for the vcpkg port #541

bangusi opened this issue Jan 27, 2020 · 6 comments
Assignees
Labels

Comments

@bangusi
Copy link

bangusi commented Jan 27, 2020

The default location of downloads makes no sense. The downloads folder is for transient files.
So how do I customize the location when using the library built by vcpkg?

@HowardHinnant
Copy link
Owner

Here are the build instructions I recommend: https://howardhinnant.github.io/date/tz.html#Installation

There also exists a set_install function that you can call at run-time prior to first use of the database.

@bangusi
Copy link
Author

bangusi commented Jan 28, 2020

I had visited the installation page before posting the question. But I got the library through vcpkg,
The installation is simply vcpkg install date:x64-windows-static. Was wondering if there was a way to influence where the tzdb goes through vcpkg. I guess I will go with the set_intall function

@bangusi bangusi closed this as completed Jan 28, 2020
@HowardHinnant
Copy link
Owner

If you like, re-open this issue and I'll label it with "CMake", and perhaps those interested in maintaining that build system will suggest better options, or modifications to the CMake build system.

@mellery451
Copy link
Contributor

I haven't followed, but aren't we just talking about

date/src/tz.cpp

Lines 226 to 232 in 9a0ee25

// Usually something like "c:\Users\username\Downloads".
static
std::string
get_download_folder()
{
return get_known_folder(FOLDERID_Downloads);
}
? If there is something the build system can do to override or make this more configurable by packages/installers, I'm happy to make that change.

@HowardHinnant
Copy link
Owner

Thanks Mike. At this point I don't know. But your willingness to help is much appreciated.

@bangusi bangusi reopened this Jan 28, 2020
@bangusi
Copy link
Author

bangusi commented Jan 28, 2020

Re-opened as suggested so can be properly addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants